Add an experimental GCSDownloader for HTTPS Collection support#1342
Open
sirosen wants to merge 3 commits intoglobus:mainfrom
Open
Add an experimental GCSDownloader for HTTPS Collection support#1342sirosen wants to merge 3 commits intoglobus:mainfrom
sirosen wants to merge 3 commits intoglobus:mainfrom
Conversation
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
sirosen
force-pushed
the
experimental-gcs-downloader
branch
2 times, most recently
from
e991f07 to
2fa56e4
Compare
This is an implementation of HTTPS download from GCS collections via Location header sniffing, which is the only mechanism we have available on all GCS versions for translating a URL to a client ID.
Argument parsing isn't essential to the example, and therefore its removal simplifies in a beneficial way for the reader.
There is now a separate client object for HTTPS accessible collections. This requires refactoring the GCSDownloader slightly, to use this client. In the course of these changes, the "client constructor" protocol has been removed, as it is deemed unnecessary until proven otherwise.
sirosen
force-pushed
the
experimental-gcs-downloader
branch
from
4deb394 to
2f5cd8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial experimental implementation, not necessarily our long-term interface.
It solves the most important problem in handling HTTPS for GCS, which is translating a file URL into a collection ID.
The interface is the part most subject to potential future refinement, as it's not clear how to provide the right level of control over
This is an implementation of HTTPS download from GCS collections via
Location header sniffing, which is the only mechanism we have available
on all GCS versions for translating a URL to a client ID.
New doc link: https://globus-sdk-python--1342.org.readthedocs.build/en/1342/experimental/gcs_downloader.html#example-usage